run-queue: Extend queue capability check to job-runner #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With job-runner, the bits that actually need /dev/kvm don't run in the "queue monitor" task container any more, but in separate containers. We want to drop importing /dev/kvm into the monitor container [1], so extend the check to also accept the presence of a job-runner configuration. With that we can drop the check for `COCKPIT_TESTMAP_INJECT` -- that was just a hack, and the cockpituous integration tests define `JOB_RUNNER_CONFIG` already. [1] cockpit-project/cockpituous#590
6 tasks
|
I reran the job now that we landed the cockpituous changes. |
allisonkarlitskaya
approved these changes
Mar 13, 2024
martinpitt
added a commit
to cockpit-project/cockpituous
that referenced
this pull request
Mar 13, 2024
With the run-queue fix [1] landed, we don't need this as indicator for "capable of running tests" any more. cockpit-project/bots#6080
allisonkarlitskaya
pushed a commit
to cockpit-project/cockpituous
that referenced
this pull request
Mar 13, 2024
With the run-queue fix [1] landed, we don't need this as indicator for "capable of running tests" any more. cockpit-project/bots#6080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With job-runner, the bits that actually need /dev/kvm don't run in the "queue monitor" task container any more, but in separate containers. We want to drop importing /dev/kvm into the monitor container [1], so extend the check to also accept the presence of a job-runner configuration.
With that we can drop the check for
COCKPIT_TESTMAP_INJECT-- that was just a hack, and the cockpituous integration tests defineJOB_RUNNER_CONFIGalready.[1] cockpit-project/cockpituous#590
Tests are blocked on cockpit-project/cockpituous#590 , as currently they use the cockpituous/main tests with the refreshed tasks container from that PR.